[Webkit-unassigned] [Bug 26375] VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 23:17:35 PDT 2009


------- Comment #18 from tyoshino at google.com  2009-06-23 23:17 PDT -------
(In reply to comment #16)
> (From update of attachment 31531 [review])
> Wow!  Thank you for the awesome investigation.
> Unfortunately the current patch doesn't seem to actually have the code change,
> just a comment?
> This is the only log message you need in the ChangeLog:
> WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that
> cannot be represented in the current code page (932). Save the file in Unicode
> format to prevent data loss
> The rest of the build output you can remove from the ChangeLog.

OK. Thanks.

> r- for lack of code change.  Otherwise I'd r+ this.  Thanks again for the
> investigation!

As Darin said, if I make code change on WebCoreLocalizedStrings.cpp without
making change on extract-localized-strings script, I'll break Localized.strings
generation process. Do you mean I should make change on
extract-localized-strings instead of putting a comment?


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list