[Webkit-unassigned] [Bug 26666] bugzilla-tool continues execution even if subcommands fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26666


levin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31760|review?                     |review+
               Flag|                            |




------- Comment #4 from levin at chromium.org  2009-06-23 18:11 PDT -------
(From update of attachment 31760)
Only one comment:

> diff --git a/WebKitTools/Scripts/modules/scm.py b/WebKitTools/Scripts/modules/scm.py
> +    def run_command(command, cwd=None, input=None, raise_on_failure=True, return_exit_code=False):
> +        stdin = subprocess.PIPE if input else None
> +        process = subprocess.Popen(command, stdout=subprocess.PIPE, stdin=stdin, shell=True, cwd=cwd)
> +        output = process.communicate(input)[0].rstrip()
> +        exit_code = process.wait()
> +        if raise_on_failure and exit_code != 0:

Use:
        if raise_on_failure and exit_code:


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.