[Webkit-unassigned] [Bug 26659] Support hidding an control bar element from the Media element controller.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26659


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31745|review?                     |review-
               Flag|                            |




------- Comment #3 from eric at webkit.org  2009-06-23 17:37 PDT -------
(From update of attachment 31745)
You ChangeLog is missing the bug url.

Style:
+    if(m_isHidden)
+    if(!m_mediaElement || !m_mediaElement->renderer())
+    if (!renderer() && !m_isHidden && style->display() != NONE)
+    {
+        if (renderer)
+        {

When does this ever return NULL?
+        RenderObject* renderer =
createRenderer(m_mediaElement->renderer()->renderArena(), style);

Why don't we just early-return in that case?

Why manually set attached instead of calling attach?
+            setAttached();


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.