[Webkit-unassigned] [Bug 26529] [Chromium] Pipe getFontDataForCharacters via ChromiumBridge

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 15:58:14 PDT 2009


------- Comment #2 from levin at chromium.org  2009-06-23 15:58 PDT -------
(From update of attachment 31520)
I'm leaving the "real" review for Darin Fisher, but I'll give you some style
things to fix up to make it go faster.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2009-06-18  Adam Langley  <agl at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Typically the link to the bug is near the top of the change log entry.  (I did
see you put it in bug it way at the bottom.)

> diff --git a/WebCore/platform/chromium/ChromiumBridge.h b/WebCore/platform/chromium/ChromiumBridge.h
> +        static String getFontFamilyForCharacters(const UChar* characters, int numCharacters);

"characters" doesn't seem to add any information here due to the api name and
the const UChar* type.
So it would be good to remove it.  (WebKit style is to not put in param names
when they don't add information.)

> diff --git a/WebCore/platform/graphics/chromium/FontCacheLinux.cpp b/WebCore/platform/graphics/chromium/FontCacheLinux.cpp
> +    String family = ChromiumBridge::getFontFamilyForCharacters(characters, length);
> +    if (family.isEmpty())
> +        return NULL;

Use 0 instead of NULL.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list