[Webkit-unassigned] [Bug 26279] REGRESSION: typing in gmail pegs CPU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26279





------- Comment #25 from ojan at chromium.org  2009-06-23 12:30 PDT -------
Mitz, very sorry about all the style errors. I'll get used to WebKit style
someday. :)

All done except below.

> > +    if (property->id() == CSSPropertyFontSize && property->value()->isPrimitiveValue() && m_node && m_node->computedStyle()) {
> 
> The old code called Document::updateLayoutIgnoringPendingStylesheets() before
> calling computedStyle(). Why is it safe to not update layout here?

Which old code? I don't know if it's safe to call computedStyle here. Really
that depends on who is calling diff, right? I was just mimicking
copyInheritableProperties. Should we be updating layout in
copyInheritableProperties as well?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.