[Webkit-unassigned] [Bug 26537] Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26537





------- Comment #20 from tyoshino at google.com  2009-06-22 21:07 PDT -------
(In reply to comment #16)
> (From update of attachment 31638 [review])
> I think we could go further and just remove that file!
> 
> r=me
> 

OK. Done.

(In reply to comment #17)
> (From update of attachment 31638 [review])
> This logic should go in webkitdirs.pm, near where we determine whether we need
> to add any custom options to xcodebuild in relation to the build product
> directory.  That code is also used by the Makefiles, so it would be good to
> have the workaround affect both build-webkit and the Makefiles.  I also think
> that removing the file silently if it exists is a better option, as we're just
> asking the user to do something we can trivially do ourselves.  In addition,
> it'd be great if you could update the comment to refer to the Radar number I
> mentioned, so that in the future we can quickly determine why the workaround
> exists and if it is still needed.  Something like the following should suffice:
> 
>    # The presence of ~/Library/Preferences/xcodebuild.plist can prevent
> xcodebuild from respecting global settings such as a custom build products
> directory (<rdar://problem/5585899>).
> 

Done. Please take a look again.

Thanks,


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.