[Webkit-unassigned] [Bug 26629] Refactor localStorage code for use in multi-process browsers (part 2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26629





------- Comment #6 from jorlow at chromium.org  2009-06-22 18:08 PDT -------
(In reply to comment #5)
> I see now that the expected optimization with set/remove/clear was never
> actually there.  The code was complicated like this for that very reason.
> 
> getItem() was the one I actually already knew there was a flaw with  ;)
> 
> My concern stands in a new form - changing the fine grain code to a big heavy
> block(), it seems to me the fine grained code will just have to be
> re-introduced at some point to get closer to the original intended
> optimizations.

I agree.  Originally I tried to leave it in, but the patches were much uglier. 
I figured since we weren't actually losing functionality it was OK, but my
guilt is why I put that huge FIXME in.  I'll create a bug for it now.  :-)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.