[Webkit-unassigned] [Bug 26328] Changing href attribute of svg images does not work when changing display attribute as well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26328


rwlbuis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31598|0                           |1
        is obsolete|                            |
  Attachment #31666|                            |review?
               Flag|                            |




------- Comment #10 from rwlbuis at gmail.com  2009-06-22 12:34 PDT -------
Created an attachment (id=31666)
 --> (https://bugs.webkit.org/attachment.cgi?id=31666&action=view)
Back to fixing SVGImageElement::svgAttributeChanged

These changes were made:

- I went back to the original fix. Since svgAttributeChanged is there for SVG
and parseMappedAttribute is not called for the JS bindings, I tried to fix up
SVGImageElement::svgAttributeChanged. Basically the xlink:href handling is
singled out first and done independent of renderer() being there or not. The
rest is as before, I hope the code is more readable than in the first patch. I
guess in the long run svgAttributeChanged should go (is there a bug for that?).
- I added a test for the href.baseValue setting alternative, which does not end
up in parseMappedAttribute.
- I updated the ChangeLogs because it also fixes bug 26392.
Cheers,

Rob.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.