[Webkit-unassigned] [Bug 26612] Notify of profile start in console

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 22 11:28:02 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26612


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31656|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2009-06-22 11:28 PDT -------
(From update of attachment 31656)
> -    void addProfileMessageToConsole(PassRefPtr<JSC::Profile> prpProfile, unsigned lineNumber, const JSC::UString& sourceURL);
> +    void addProfileFinishedMessageToConsole(PassRefPtr<JSC::Profile> prpProfile, unsigned lineNumber, const JSC::UString& sourceURL);

Should omit the name prpProfile here.

>      void addScriptProfile(JSC::Profile* profile);

And the name profile here.

>      const ProfilesArray& profiles() const { return m_profiles; }
>  
> +                // The title is used in the console message announcing that a profile has started so it get's

No apostrophe needed in gets.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list