[Webkit-unassigned] [Bug 26366] [V8] Teach V8 bindings about isolated worlds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26366


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31640|review?                     |review+
               Flag|                            |




------- Comment #8 from dglazkov at chromium.org  2009-06-22 10:06 PDT -------
(From update of attachment 31640)
Just a few styling nits:

> +static char kIsolatedWorldKey[] = "IsolatedWorld";

You don't have to have prefixes (k* or g_*) for statics.

> +static int g_isolatedWorldCount = 0;

> +    // Using the default security token means that the canAccess is always
> +    // called, which is slow.
> +    // TODO(aa): Use tokens where possible. This will mean keeping track of all
> +    // created contexts so that they can all be updated when the document domain
> +    // changes.

FIXME?

> +    // TODO(abarth): Move this statement above proxy->evaluate?  It seems like
> +    //               we should set up the token before running the script.

FIXME?

> +V8IsolatedWorld* V8IsolatedWorld::getEntered()
> +        return NULL;

return 0;

> +        return NULL;

ditto.

> +        return NULL;

ditto.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.