[Webkit-unassigned] [Bug 26537] Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26537





------- Comment #14 from tyoshino at google.com  2009-06-22 01:15 PDT -------

> > So, what's the best thing to do in this function? It's confusing that it has
> > unnecessary code for setting baseProductionDirOption here.
> 
> What unnecessary code are you referring to?  baseProductDirOption is set in two
> places: one place deals with the situation where Xcode has a global build
> product directory configured (no extra options necessary), and the other deals
> with the default behavior of placing the build product directory alongside the
> project (we override SYMROOT and OBJROOT to force things in to a single
> directory for all projects). 
> 
Sorry, I was misunderstanding. I got it. The code is completely correct.

> It may be that this logic could be cleaner or more explicit, but that is
> something that would be best done in a separate patch.
> 

All right. Will do.

Thank you for review, Mark and Eric.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.