[Webkit-unassigned] [Bug 26120] Honor Desired Weight and Italic State for Fonts in Windows Cairo Build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26120





------- Comment #8 from lunaris at tmax.co.kr  2009-06-21 04:30 PDT -------
r44268 from Bug 21492 corrected the problem of Korean bold font rendering. 
Since most of Korean fonts (bundled with MS Windows) don't have bold data,   
they should be rendered as synthetic-bold. 

The changes to the matchImprovingEnumProc() is just a little optimization. 

Currently, matchImprovingEnumProc enumerates all fonts proposed by GDI.
If it don't need to improve anything other than italic & weight, it can
be stopped when it's proposed same weight & italic by GDI. 

Sorry for the bugs in the changes. First if block need to be modified 
to return 1 when firstMatch is true to keep original logic. 
(candidate is always chosen in first match) And, in second if block, 
the change removes all '!' operators comparing lfitalic fields, 
but it is my mistake. The original code implies much more complex 
(and hard to understand) logic. 

I think it's better to keep current matchImprovingEnumProc() if there's
no clear evidence it slows down font creation. 

But, about the other changes to creatGDIFont(), 
I'm still wonder why we have to embolden fonts manually. 
I changed the createGDIFont() before r44268 landed, and saw it works. 
That means cairo can draw synthtic-bold fonts by itself. 
Is there any reason that I don't know yet? 

Anyway, This issue can be closed. Thank you.  


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.