[Webkit-unassigned] [Bug 26580] Fix to enable XSSAuditor on child windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26580


abarth at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31606|review?                     |review+
               Flag|                            |




------- Comment #2 from abarth at webkit.org  2009-06-21 00:48 PDT -------
(From update of attachment 31606)
Thanks Dan!  Below are some minor style nits.  I'll fix them before landing the
patch.

> +XSSAuditor::XSSAuditor(Frame* frame) : m_frame(frame)

The ": m_frame" bit should be on the next line.

> +    layoutTestController.dumpChildFramesAsText();

The test doesn't create any child windows, so this call doesn't do anything.

> +    var event = document.createEvent('MouseEvent');
> +    event.initEvent('click', true, true);
> +    document.getElementById('anchorLink').dispatchEvent(event);

I think the anchor tag has a click() method that would be eaiser, but this does
the job.

> +if (window.layoutTestController) {
> +  layoutTestController.notifyDone();
> +}

No braces needed for if statements with single-line bodies.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.