[Webkit-unassigned] [Bug 26474] WML Card Title does not get displayed on GtkLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26474


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31540|review?                     |
               Flag|                            |




------- Comment #6 from zimmermann at kde.org  2009-06-20 08:16 PDT -------
(From update of attachment 31540)
Looks good except the const_cast. Just make the
parseValueSubstitutingVariableReferences & parseValueForbidding... functions
const. They're not modifying any member variables and they are non-const by
mistake. Can you upload a new patch?

As you don't have commit access I'm going to clear the review flag until a new
patch has been uploaded. Going to commit that patch then.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.