[Webkit-unassigned] [Bug 26409] [GTK] Glitches in new progress/load-status system

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 20 05:45:46 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26409


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31594|review?                     |review+
               Flag|                            |




------- Comment #4 from jmalonzo at gmail.com  2009-06-20 05:45 PDT -------
(From update of attachment 31594)
> index 802a56b..34d5ced 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,11 @@
> +2009-06-20  Gustavo Noronha Silva  <gns at gnome.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Initial test case for loading.

Need to be more descriptive here.

> +static void
> +load_finished_cb(WebKitWebView* web_view, WebKitWebFrame* web_frame, gpointer data)
> +{

Please put this in one line to match the other tests.

> +    return g_test_run ();

remove spaces.

r=me with these changes. 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list