[Webkit-unassigned] [Bug 26474] WML Card Title does not get displayed on GtkLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26474


zimmermann at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31404|review?                     |review-
               Flag|                            |




------- Comment #3 from zimmermann at kde.org  2009-06-18 10:21 PDT -------
(From update of attachment 31404)
Hi Wajat,

thanks for the patch. Good that you spotted it, though I'd suggest a better
implementation of that.
WMLCardElement already provides a virtual-function "String title() const"
through the Element parent class.

So all you'd need to do is implement WMLCardElement::title() and have it return
"parseValueSub...(getAttribute(titleAttr...". See HTMLElement::title() for
comparision.
This way we save memory. Glad if you could upload a new patch.

Niko


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.