[Webkit-unassigned] [Bug 25689] [Qt] Implement SearchPopupMenuQt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25689


treat at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30606|review?                     |review-
               Flag|                            |




------- Comment #11 from treat at kde.org  2009-06-18 10:09 PDT -------
(From update of attachment 30606)
> +        past search queries should be used for search fields. The search queries will be
> +        store with QSettings, for this to work make sure to call

Minor nit, but that should be 'stored' I believe.

>  void SearchPopupMenuDelegate::saveRecentSearches(const AtomicString& name, const Vector<String>& searchItems, Document*)
>  {
> +    if (name.isEmpty())
> +        return;
> +
> +    // put into the QStringList
> +    QStringList urls;
> +    for (int i = 0; i < searchItems.size(); ++i)
> +        urls.append(searchItems[i]);

Shouldn't we have a maximum number of entries here?

Adam


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.