[Webkit-unassigned] [Bug 22384] svg <text> fails to update when setting x/y

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 09:01:27 PDT 2009


------- Comment #7 from rwlbuis at gmail.com  2009-06-18 09:01 PDT -------
Hi Maciej,

(In reply to comment #6)
> (From update of attachment 31027 [review])
> I'm pretty sure that handling this in the JS bindings is the wrong layer. Won't
> that mean other language bindings, or mutation via the core C++ interfaces,
> have the same bug? I think the notification should be at the core object level,
> or else we need to provide a generic way to do it for all language bindings and
> apply it to, for instance, the ObjC bindings.
> The code itself looks fine, but r- to consider this change of approach.

Thanks for the review!

I do agree that that would be the better design. However I think that right now
only the (js) bindings have enough context to know what node to notify, ie.
SVGList.cpp and for example SVGPointList.cpp do not know that. I did not follow
the POD work too closely so I do not know if that is the only way for it to
work, WildFox or eseidel should know more about that. I'll try to contact one
of them to find out what is best to do in this case.


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list