[Webkit-unassigned] [Bug 26509] Use constants instead of 11 and 12 in HTMLTokenizer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 01:32:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26509





------- Comment #3 from scarybeasts at gmail.com  2009-06-18 01:32 PDT -------
You probably want to use you new constant here too in case it ever changes and
gets things out of sync:

       case Hexadecimal: {
            int ll = min(src.length(), 10 - cBufferPos);

and a few lines later.....

            if (cBufferPos == 10)
                state.setEntityState(SearchSemicolon);


Also note that for some reason a "decimal" entity has a different limit of 9
chars:

        case Decimal:
        {
            int ll = min(src.length(), 9-cBufferPos);
...
             if (cBufferPos == 9)
                state.setEntityState(SearchSemicolon);

And a named entity also 9 chars, with further magic dependence on this
constant:

        case EntityName:
        {
            int ll = min(src.length(), 9-cBufferPos);
...
            if (cBufferPos == 9)
                state.setEntityState(SearchSemicolon);
...
                    char tmpEntityNameBuffer[10];

                    ASSERT(cBufferPos < 10);


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list