[Webkit-unassigned] [Bug 26425] Small Refactoring to Consolidate Common GDI Calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26425


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31465|review?                     |review+
               Flag|                            |




------- Comment #16 from aroben at apple.com  2009-06-17 16:45 PDT -------
(From update of attachment 31465)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,31 @@
> +2009-06-17  Brent Fulgham  <bfulgham at webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Refactor a few common routines in the various Windows ports
> +        and reduce some duplicated code.
> +
> +        Refactor use of BITMAPINFO for the new BitmapInfo structure.

You should mention the Bugzilla URL in your ChangeLog.

> +        BITMAPINFO bitmapInfo = BitmapInfo::create(dstRect.size());

Might as well use BitmapInfo here, too.

You could give BitmapInfo a constructor that initialized bmiHeader.biSize
correctly and everything else to 0. That would follow the way ATL's C++
wrappers work. Or you could leave it like you have it now.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.