[Webkit-unassigned] [Bug 26497] New: http://webkit.org/quality/testwriting.html should make more clear when/why to use dumpAsText/dumpAsMarkup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 17 15:47:34 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26497

           Summary: http://webkit.org/quality/testwriting.html should make
                    more clear when/why to use dumpAsText/dumpAsMarkup
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org


Something like:

regular tests: Tests where layout or style *rendering* is relevant.
dumpAsMarkup (when it's completed): Tests where the resultant DOM is relevant.
dumpAsText: Other tests. Should have a clear "SUCCESS" or "FAIL" message.

dumpAsMarkup and dumpAsText have a number of advantages as they don't need to
do pixel tests and are not subject to platform-specific rendering details like
font rendering:
    * reduces the number of expected results files (faster checkouts)
    * platforms rarely need to create platform-specific expected results
    * they run faster (makes run-webkit-tests faster!)

When doing dumpAsText tests, it's highly encourages to create a JS test. You
can see an example of such a test by looking at the TEMPLATE.html and js files
in LayoutTests/.../resources directories. make-js-test-wrappers generates the
appropriate HTML file for those tests and they provide a number of helper
functions to avoid code duplication across tests (e.g. testFailed, testPassed,
etc).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list