[Webkit-unassigned] [Bug 26494] New: RenderTheme::themeForPage reads from Settings before it has been initialized by WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26494

           Summary: RenderTheme::themeForPage reads from Settings before it
                    has been initialized by WebKit
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: kenneth.christiansen at openbossa.org


r44758 added RenderTheme::themeForPage and a call to it from the Page
constructor. In RenderThemeSafari.cpp, the themeForPage implementation using
Settings to decide which instance of a RenderTheme subclass to return.

But the Page constructor (and thus themeForPage) is called before Settings has
been initialized by WebKit. This caused bug 26493, though we've worked around
the issue for now. It would be better to fix the design problem here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.