[Webkit-unassigned] [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26148


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31299|review?                     |review+
               Flag|                            |




------- Comment #29 from eric at webkit.org  2009-06-17 00:20 PDT -------
(From update of attachment 31299)
The ChangeLog is doubled.

Indent:
bool RenderThemeChromiumSkia::supportsHover(const RenderStyle* style) const
 141 {
 142   return true;
 143 }

Unused parameters can cause warnings and thus compile failures:
bool RenderThemeChromiumSkia::supportsFocusRing(const RenderStyle* style) const
155146 {
156      return supportsFocus(style->appearance());
 147     // This causes WebKit to draw the focus rings for us.
 148     return false;
157149 }

Otherwise looks fine.  Someone could fix this when landing I guess.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.