[Webkit-unassigned] [Bug 25043] Race condition in MessagePort::clone()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25043





------- Comment #12 from levin at chromium.org  2009-06-16 23:55 PDT -------
This looks good to me.  I have only 5 very trivial comments.

1. 
It looks like you put spaces in WebCore/GNUmakefile.am where there should be
tabs.

2. 
WebCore/dom/MessagePort.cpp
157         RefPtr<Event> evt = MessageEvent::create(eventData->message(), "",
"", 0, port);
It would be just slightly better to to port.release().

3.
It looks like there is an extra blank line before void
MessagePort::contextDestroyed().

4.
In WebCore/dom/default/PlatformMessagePortChannel.h
  bool tryGetMessage(OwnPtr<MessagePortChannel::EventData>& result)

I think "message" would be better than" result".

5. 
Two parts:
  In WebCore/page/DOMWindow.cpp,
    PassRefPtr<MessageEvent> event(ScriptExecutionContext* document)
    {
I'd recommend "context" instead of "document" since you don't seem to rely on
it being a document.


        PassRefPtr<MessagePort> messagePort;
should be
       RefPtr<MessagePort> messagePort;
(and then do a release() like in #2 when creating the MessageEvent).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.