[Webkit-unassigned] [Bug 26278] Patch that make WebCore have a RenderTheme per page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26278


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31357|                            |review+
               Flag|                            |
  Attachment #31357|1                           |0
        is obsolete|                            |




------- Comment #19 from aroben at apple.com  2009-06-16 14:27 PDT -------
(From update of attachment 31357)
> From 204628441494884d406f8d75ab90ef9589bfc1ae Mon Sep 17 00:00:00 2001
> From: Kenneth Rohde Christiansen <kenneth at spisnigel.osmtc.indt.org.br>
> Date: Tue, 16 Jun 2009 15:20:27 -0300
> Subject: [PATCH] 2009-06-16  Kenneth Rohde Christiansen  <kenneth.christiansen at openbossa.org>
> 
>         Reviewed by Dave Hyatt and Adam Roben.

We normally leave this line as "Reviewed by NOBODY (OOPS!)." since a different
reviewer might review a subsequent iteration of the patch.

>  class RenderThemeGtk : public RenderTheme {
> -public:
> +private:
>      RenderThemeGtk();
>      virtual ~RenderThemeGtk();
>  
> +public:
> +    static PassRefPtr<RenderTheme> create();
> +

Our style is to list public members before private members. This can be fixed
by a committer before landing.

> +    // When the theme is needed in non-page dependent code, the defaultTheme() is used as fallback.
> +    static inline PassRefPtr<RenderTheme> defaultTheme()
> +    {
> +        return RenderTheme::themeForPage(0);
> +    };

No need for "RenderTheme::" here.

I'll fix these issues before committing.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.