[Webkit-unassigned] [Bug 25068] Complex text support for Chromium Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25068


agl at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29298|0                           |1
        is obsolete|                            |
  Attachment #31363|                            |review?(eric at webkit.org)
               Flag|                            |




------- Comment #4 from agl at chromium.org  2009-06-16 12:16 PDT -------
Created an attachment (id=31363)
 --> (https://bugs.webkit.org/attachment.cgi?id=31363&action=view)
patch

Points not addressed in code:

> Really?
> 377     // (Mac code ignores includePartialGlyphs, and they don't know what
it's
> 378     // supposed to do, so we just ignore it as well.)
> ignored arguments generally cause warnings in the compiler, no?

This comment was taken from the Windows code. The ignored argument doesn't
trigger a warning for us in either place.

> I assume this is in no way temporary?
>  321     const FontPlatformData& font = fontDataForCharacters(run.characters(), run.length())->fontDataForCharacter(' ')->platformData();

It seems to be the way to get what I need.


Cheers

AGL


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.