[Webkit-unassigned] [Bug 25475] Show the filename and first line for "(program)" in the Profiler/Debugger

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25475


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30924|review?                     |review-
               Flag|                            |




------- Comment #14 from timothy at hatcher.name  2009-06-16 11:59 PDT -------
(From update of attachment 30924)
> +    // if no URL, look for "//@ sourceURL=" decorator     

This comment should mention that this matches what Firebug looks for and not
somthing we made up. Also remove the trailing whitespace.

> +        // use of [ \t] rather than /s is to prevent \n from matching

This comment references /s which whould be \s.

> +        if (match) {
> +            this.sourceURL = "(eval):" + match[1];
> +        }

No need for the braces around the if body. Remove them per our style guidlines.

Also I think this should say "(program): ". We don't use "eval" since it can be
code from setTimeout strings, new Function() or eval.

This should also be a localized string, and use WebInspector.UIString().

So WebInspector.UIString("(program): %s", match[1]).

Then add "(program): %s" to WebCore/English.lproj/localizedStrings.js.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.