[Webkit-unassigned] [Bug 26427] Use consistent Windows GUID Comparison Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26427


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31331|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2009-06-15 23:04 PDT -------
(From update of attachment 31331)
> -    if (IID_IUnknown==riid || IID_IDataObject==riid)
> +    if (IsEqualIID(riid, IID_IUnknown) || 
> +        IsEqualIID(riid, IID_IDataObject)) {
>          *ppvObject=this;
> +    }

I don't think you needed to break this into multiple lines. And when you did, I
wish you had followed the WebKit coding style (see the Indentation section,
item 6, and the Braces section, item 3).

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.