[Webkit-unassigned] [Bug 26366] Teach V8 bindings about isolated worlds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26366


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31227|review?                     |review-
               Flag|                            |




------- Comment #3 from dglazkov at chromium.org  2009-06-15 13:39 PDT -------
(From update of attachment 31227)
Holy moly! You rewrote the world! I think I understand what the patch is doing,
especially with the Reitveld companion.

My concerns are:

* v8_isolated_world should live upstream, in bindings/v8.
* How does this affect bindings performance?
* Make sure there are no layout test regressions.

Review comments:

No ChangeLog? :)

> +    private:
> +      DOMData* m_domData;

4 spaces?

> +    static void handleWeakObject(DOMDataStore::DOMWrapperMapType mapType,
> +                                 v8::Handle<v8::Object> v8Object,
> +                                 T* domObject);

No need to wrap here -- it's WebKit-land :)

> +DOMDataStoreHandle::DOMDataStoreHandle()
> +    : m_store(new ScopedDOMDataStore(DOMData::getCurrent()))  // TODO: Fix!

FIXME: and What?

> +void visitDOMNodesInCurrentThread(DOMWrapperMap<Node>::Visitor* visitor) {

Brace on new line.

> +void visitDOMObjectsInCurrentThread(DOMWrapperMap<void>::Visitor* visitor) {

Ditto.

> +void visitActiveDOMObjectsInCurrentThread(DOMWrapperMap<void>::Visitor* visitor) {

Ditto.

> +void visitDOMSVGElementInstancesInCurrentThread(DOMWrapperMap<SVGElementInstance>::Visitor* visitor) {

Ditto.

> +void visitSVGObjectsInCurrentThread(DOMWrapperMap<void>::Visitor* visitor) {

Ditto.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.