[Webkit-unassigned] [Bug 26379] Reconsider image decoding architecture/APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26379





------- Comment #42 from bfulgham at webkit.org  2009-06-15 11:43 PDT -------
(In reply to comment #41)
> 2) ... I've seen pkasting mention that the current Vector<unsigned> is
> suboptimal for Cairo and WX, but I haven't seen the details of what this will
> move to and whether or not there is any possibility Cairo/WX/FooPort can share
> the future backend data store.  It'd be nice to have more info please.

As Holger pointed out, Cairo can 'adopt' memory (without copy) so there does
appear to be less of a performance impact than initially thought.  However,
there might be some advantages gained by calling some of the
cairo_surface_t-based calls rather than performing math on the raw vectors, and
I think this should be considered as a potential performance gain.

> Con:
> 2) Duplication of effort with ImageBuffer

Well, the point of this current bug is to move much of the RGBA32Buffer logic
to ImageBuffer, so perhaps this isn't really a con so much as an active
development goal.

> RE: Brett
> 
> Peter has made very valuable contributions to the image-decoders.  No one
> disputes that.  However, _so far_ I have a hard time seeing the benefits to the
> other ports in the recent changes other than the opportunity to share the code
> with the Skia port.  Maybe I'm not reading something correctly...

We now have image-decoder implementations for BMP, XBM, and ICO, which did not
previously exist.  GTK+, wxWindows, and Cairo can now use these implementations
which I do consider to be benefits to these other ports.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.