[Webkit-unassigned] [Bug 26278] Patch that make WebCore have a RenderTheme per page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26278


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31201|review?(hyatt at apple.com)    |review+
               Flag|                            |




------- Comment #8 from hyatt at apple.com  2009-06-15 09:29 PDT -------
(From update of attachment 31201)
I don't think you ever have to null-check page() in the RenderObject::theme()
method... you can just make that method return document()->page()->theme() and
not worry about the else case.

You should inline defaultTheme() in the header.

I think it would read better if defaultTheme() was a static member function of
RenderTheme also at this point.  You can just put it next to themeForPage().

I'm going to go ahead and give this r=me though.  If you fix those things,
great.  If not, can be fixed in followup patch also.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.