[Webkit-unassigned] [Bug 26404] New: Pasteboard::generalPasteboard leaks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26404

           Summary: Pasteboard::generalPasteboard leaks
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mihnea at adobe.com


Hi,

Every time it is called, function generalPasteboard() from
WebCore\platform\win\PasteboardWin.cpp is leaking since it is creating the
Pasteboard object every time.

Current code:
Pasteboard* Pasteboard::generalPasteboard() 
{
    static Pasteboard* pasteboard = new Pasteboard;
    return pasteboard;
}

I think it should probably be as in PasteboardQt.cpp:
Pasteboard* Pasteboard::generalPasteboard() 
{
    static Pasteboard* pasteboard = 0;
    if (!pasteboard)
        pasteboard = new Pasteboard();
    return pasteboard;
}

The problem is present in PasteboardChromium.cpp, PasteboardGtk.cpp and
PasteboardWx.cpp.

Regards,
Mihnea


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.