[Webkit-unassigned] [Bug 26379] Reconsider image decoding architecture/APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26379





------- Comment #34 from zecke at selfish.org  2009-06-14 23:40 PDT -------
(In reply to comment #33)
> (In reply to comment #27)
> >           (as the image data was not copied and the cairo_image_surface was
> > created exactly once, at least to what I think is right)
> 
> BTW Brent, I think this is correct, and may actually be a bug.  From my reading
> of some of the Cairo docs today, cairo_image_surface_create_for_data() doesn't
> copy the data, which means your returned surface is at the merge of the
> lifetime of the RGBA32Buffer -- which is managed by the ImageDecoder, which may
> delete it (see e.g. clear()).  I don't think it's safe to have the frames
> returned from the ImageSource depend on the vagaries of the ImageDecoder.  I
> assumed this code was copying since wx copies, Skia refs, and when we used to
> have a different backing implementation here, we had all kinds of problems
> until we ensured that the lifetimes were separate.

I'm not aware of any crash/issue with the Cairo backend, I don't remember
seeing a crash in it since 2007... anyway. I take that as an ACK that the
default implementation of Vector<PixelData> can be the "optimized" version for
some platforms?

See, it would be so much easier if you would ack when you mess things up...
Until now you are not even able to ACK that you made something that was
cross-platform need platform specific code. Instead you defend it by saying
"Copy and Paste ain't bad." and that Skia is the 2nd most often used platform.
Please at least ack that you removed the cross platform property. 

See I honestly care about all ports and making their life more easy and I'm
just afraid you continue this way (making code less portable).

 greetings from your general reviewer, Gtk+, Qt maintainer and janitor.

PS: Maybe just ack that your changes made things less portable?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.