[Webkit-unassigned] [Bug 26379] Reconsider image decoding architecture/APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26379





------- Comment #23 from pkasting at google.com  2009-06-14 18:52 PDT -------
(In reply to comment #20)
> 3.  As for the EFL and Windows CE ports, these are basically Qt ports, so this
> sounds akin to arguing that "pkasting broke the Qt port, and he also broke the
> Qt port and the other Qt port to boot."

Plus, I asked repeatedly both on bugs and IRC for input from Qt port
maintainers to ensure that my changes didn't break Qt, and it was my impression
that Qt _isn't_ broken.  None of the Torchmobile or EFL people have asked for
help in any way.  The only bustage to Qt I'm aware of was the the temporary
bustage about 48 hours ago that I _had already said I was planning to fix_ and
that _was_ in fact worked around with a roughly 3-line patch (not a "115 line
copy").

These comments boil down to "you kept other ports working by copying a few
functions' implementations temporarily.  THIS IS AN ENORMOUS PENALTY!"  I think
it's clear that this isn't an "enormous penalty" or in fact much of any
penalty, since it applies to exactly _two_ ports (not CG, the most widely used
port as part of Safari; not Skia, the second most widely used port as part of
Chromium; and not QT, the port I broke so apparently badly), and in fact _I_
was the one that made the changes for those other ports, not those ports'
maintainers (although kollivier on IRC last night said the changes "sounded
easy" before I went ahead and wrote the wx patch, so even that wasn't a big
deal).  I could alternately have provided an ImageDecoder.cpp that implemented
these two ports' functions for things they have in common at the moment, but
this seemed like just causing the ports additional hassle since as Brent said
in comment 21 things are about to change even more.

In summary, Holger, you are arguing that I have caused great pain to wx and
Cairo, but the only thing I've caused is my _own_ patches to implement some
functions that are shortly going to differ between the two ports, the Cairo
maintainer doesn't agree with your position, and the wx maintainer has not
spoken.  And you give little indication as to whether the idea of moving
RGBA32Buffer into a class in graphics/ would satisfy you at all: some of your
comments sound as if it would, but they are so tangled in comments about how I
must reverse my patches (rather than simply move toward merging these two
classes, which is surely easier now if I've actually made RGBA32Buffer more
like ImageBuffer) that I don't know what to think.

This isn't productive dialog at all.  Be reasonable and stop trying to use
other ports as weapons against me when their maintainers disagree with you or
are silent.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.