[Webkit-unassigned] [Bug 14550] Non-layout style change does not update nested first-letter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14550





------- Comment #3 from simon.fraser at apple.com  2009-06-14 17:30 PDT -------
Notes from irc conversation:

dhyatt: setStyle is top down
5:22pm dhyatt: so you get to the outermost block with first-letter on it
5:22pm dhyatt: and update its style to be green
5:22pm dhyatt: so then the cached first letter style is also green
5:22pm dhyatt: or would be
5:22pm dhyatt: it just inherits
5:22pm dhyatt: but the issue is when you make a pseudo style
5:22pm dhyatt: you pass in a parent
5:23pm dhyatt: and you are passing in the first line style of the <span>
5:23pm dhyatt: and he has not yet been properly updated
5:23pm smfr: ah
5:23pm dhyatt: so his color is black
5:23pm dhyatt: so the first letter style inherits from that
5:23pm dhyatt: later on the <span> is going to update
5:23pm dhyatt: to green
5:23pm dhyatt: but because he;'s a RenderInline
5:23pm dhyatt: first letter isn't updated
dhyatt suspects you may need some kind of updateFirstLetter that runs in both
cases
5:24pm dhyatt: for both RenderInline and RenderBlock
5:24pm dhyatt: if you had that you could probably simplify a lot
5:24pm smfr: so this bug is more involved than I thought
5:24pm dhyatt: since you wouldn't have to drill if you eventually found the
right object
5:24pm dhyatt: it's very involved yes

dhyatt: smfr: here are the issues as i see them....
5:26pm dhyatt: i.e., my laundry liust of first-letter problems
5:26pm dhyatt: list
5:26pm dhyatt: (1) we do a full-blown Detach when first-letter rules change. 
that sucks.
5:26pm dhyatt: but is not the end of the world
5:26pm dhyatt: in fact this basically means that first-letter being updated
only needs to happen because of inheritance
5:26pm dhyatt: and not for any other reason
5:27pm dhyatt: and since first-letter objects have to be the child of either a
RenderInline or RenderBlock
5:27pm dhyatt: i think you could just rewrite updateFirstLetter
5:27pm dhyatt: to be a common function to both
5:27pm dhyatt: like before/after stuff
5:27pm smfr: yep
5:27pm dhyatt: then finding it for updating would be really simple
5:28pm dhyatt: but really i do hate that we do a detach when first-letter
styles change


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.