[Webkit-unassigned] [Bug 26379] Reconsider image decoding architecture/APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26379





------- Comment #21 from bfulgham at webkit.org  2009-06-14 16:45 PDT -------
(In reply to comment #5)
> Created an attachment (id=31259)
 --> (https://bugs.webkit.org/attachment.cgi?id=31259&action=view) [review]
> Make ImageDecoder.cpp cross-platform
> 
> There is no need to force every port to have the exact same implementation of
> RGBA32Buffer, the only symbol that is platform depended is the conversion to a
> NativeImage and that does not belong into the buffer class anyway.

I think there is a good reason for these methods to be backend-dependent.  As
with Skia, the Cairo port will refer to the internal image buffer (rather than
the array of bytes) to provide the implementations for these method calls.

I agree it looks a little silly right now, since the wx and Cairo ports are
nearly identical, but I am planning to revise the Cairo version of this file to
use internal Cairo buffer/image handling routines which will remove the seeming
duplication here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.