[Webkit-unassigned] [Bug 26379] Reconsider image decoding architecture/APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26379





------- Comment #16 from bfulgham at webkit.org  2009-06-14 10:29 PDT -------
Another point in all this work is that the benefit of unforking Chromium's code
is a huge benefit to the WebKit project, especially ports like GTK+/Windows
Cairo that do not have access to the same development resources as Qt or Apple.
 Prior to Peter's modifications, all the Cairo ports were unable to view
XBM/ICO/BMP files, and with virtually no effort on our parts we now have these
features.  I look forward to receiving other great new functionality and bug
fixes as Google moves forward updating these now-shared image decoders as their
team finds bugs, fixes performance issues, and so forth.

I am frankly dismayed by the poor attitude displayed in IRC and these bugs
towards this work.  Google did not receive any benefit from doing this work,
but the Linux and redistributable Windows ports gained significant useful
functionality.  And the fact that as far as I can tell the majority of the
objection boils down to a tirade over the presence of #ifdef guards in the
header (perhaps temporarily) seems like a major overreaction.

It's nice that various embedded projects use the Qt environment and perhaps use
the ImageDecoder stuff (which as far as I can tell is unimpeded by these
changes).  But there are also cell phone companies, Windows API-compatible
embedded projects, the Titanium project, and people that wish to have a
redistributable WebKit on Windows that use the Windows Cairo port, as well as
the myriad of Linux-based teams that use the GTK+ port, that will greatly
benefit from these changes.

Backing Peter's changes out now will adversely affect all of these projects.

Now, can we please discuss how to make the image decoders *better*, rather than
trying to undo history?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.