[Webkit-unassigned] [Bug 25899] [Chromium] PC Chromium: keyboard selection in Hebrew select element doesn't work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 12 15:06:34 PDT 2009


------- Comment #13 from xji at chromium.org  2009-06-12 15:06 PDT -------
(In reply to comment #12)
> (From update of attachment 30970 [review])
> Style:
> +static bool isCharacterTypeEvent(const PlatformKeyboardEvent& event) {
> I'm confused why PopupListBox is in this file at all.  Generally WebKit has
> one-class-per-file.

I do not know why it is there originally. Maybe someone more familiar with the
file history knows it better.

> Why doesn't WebKitWin need this same code?  Or does it already have it?

WebKitWin also has a similar function:  SelectElement::typeAheadFind(), but it
is called only when the event type is Char type, that is why it does not need
to check inside the method.
The caller is: SelectElement::defaultEventHandler(), in which, it checks
whether isPrintableChar(keyboardEvent->charCode()) is true before calling
KeyboardEvent::charCode() returns character code for keypress, 0 for keydown
and keyup.

PopupListBox::typeAheadFind() is called by PopupListBox::handleKeyEvent(),
which handles all the platform keyboard events (keyup, keydown, char,
rawkeydown) from WebWidgetImpl::HandleInputEvent(), and differentiate Char type
event is needed inside typeAheadFind().

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list