[Webkit-unassigned] [Bug 26353] Incorrect Handling of Cairo Fonts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26353





------- Comment #1 from bfulgham at webkit.org  2009-06-12 13:29 PDT -------
Note: One potentially confusing coding convention is that the
cairo_font_face_t* pointers passed during construction are assumed to have a
reference count of one (i.e., they were created prior to the constructor), and
that the FontPlatformData object takes ownership.

Therefore, the main constructor does not increment the reference count, but the
copy constructor must (or else the destructor count will be out of sync).

This is probably a bad idea and should be cleaned up in a future refactoring.

Better yet, we should probably create a RefCounted class to take care of all of
this automatically.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.