[Webkit-unassigned] [Bug 26347] New: UString leaks memory when creating sharedBuffers for SmallStrings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26347

           Summary: UString leaks memory when creating sharedBuffers for
                    SmallStrings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: atwilson at google.com
                CC: levin at chromium.org


The sharedBuffer code in UString creates shared buffers for small strings,
because the code just checks the BaseString.len field which is 256 (the
BaseString is shared for all the SmallStrings).

Since the items in SmallStringStorage.m_reps never have destroy() called on
them, the sharedBuffer leaks.

I think it's a good idea to fix the bug so we don't create sharedBuffer objects
for SmallStrings, but it's also a good idea to change SmallStringsStorage to
properly clean up its contents (right now, none of its Rep instances or its
BaseString instance have their destroy() function invoked, which will
undoubtedly lead to more leaks in the future).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.