[Webkit-unassigned] [Bug 26333] alert during a dragenter event handler will crash the renderer
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 12 02:53:44 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=26333
eric at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31178|review? |review-
Flag| |
------- Comment #2 from eric at webkit.org 2009-06-12 02:53 PDT -------
(From update of attachment 31178)
You should set CHANGELOG_NAME in your environment. or REAL_NAME.
prepare-ChangeLog isn't smart enough on windows to be able to get your real
name automatically, hence:
1 2009-06-11 victorw <victorw at chromium.org>
You should mention why this needs to be a manual test (because DRT doesn't show
alerts)
Officially our style guidelines don't use { } on single line ifs:
+ if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ }
I'm not sure that our style guide is clear about that for JavaScript, so it
might not matter.
WK style is also to use more descriptive variable names:
+ var e = document.documentElement;
+ var f = function() {
+ alert('Click OK button.');
+ };
at least in code. ;)
Probably should say WebKit:
+ <p>Do the following and see if Chromium crashes.</p>
Because that will crash Safari too, no?
Otherwise looks fine. r- for the nits above.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list