[Webkit-unassigned] [Bug 25609] [GTK] Implement support for get_selection and get_n_selections

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25609


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31153|review?                     |review+
               Flag|                            |




------- Comment #13 from gns at gnome.org  2009-06-11 17:45 PDT -------
(From update of attachment 31153)
>         This is pretty hacky-ish, but I can't seem to find a direct API to
>         get the VisibleSelection for a given object, only the global one.

This should go as a comment in the code (as well?), IMO.
> +
> +    if (selection_num != 0 || !selectionBelongsToObject(coreObject, selection)) {
>          // WebCore does not support multiple selection, so anything but 0 does not make sense for now.

Probably here, extending this comment. I'd also move this comment to before the
if, so that it is clear that you are talking about the whole conditional.

Other than that, despite being hacky, this looks good.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.