[Webkit-unassigned] [Bug 24986] ARM JIT port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24986





------- Comment #23 from oliver at apple.com  2009-06-11 09:58 PDT -------
(From update of attachment 31155)
I'm not sure why you have made the changes to AssemblerBuffer.h -- they're not
needed for the v7 assembler.  I think those changes make the patch larger than
they need to be which masks the actual meaningful changes.

The changes to codeblock seems worrisome as well -- exception information is
very large (in the order of megs per page) which is why we create the
information lazily -- while i realise you are making unique constants in the
codestream is it not possible to generate the same *sized* instructions? 
Regenerating the code to create exception information merely requires the
offsets be the same, not that the code be absolutely identical.  If you can
make such a guarantee then you should be able to reduce memory usage, and
further reduce the number of changes needed to non-arm code (in general we are
trying to move to less ifdefs rather than more).

I'm not really happy with the changes to JITPropertyAccess as neither x86,
x86-64, nor ARMv7 required these changes, why do we need them in <v7 ARM?

I'm not entirely sure what Tape is -- it looks like a less generic, but
iterable version of SegmentedVector, is this a correct assessment?  Can you not
just make SegmentedVector be iterable?

I'm going to hold off r- for now (pending your response to these questions) but
i'll need gavin to review the assembler proper


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.