[Webkit-unassigned] [Bug 26297] New: Faulty logic in AccessibilityRenderObject::isSelected

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 10 13:45:23 PDT 2009


           Summary: Faulty logic in AccessibilityRenderObject::isSelected
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xan.lopez at gmail.com
                CC: jhoneycutt at apple.com

Code is:

bool AccessibilityRenderObject::isSelected() const
    if (!m_renderer)
        return false;

    Node* node = m_renderer->node();
    if (!node)
        return false;

    return false;

I'm not sure if the last 'false' was meant to be 'true', but in any case it
seems to me the function can't be right. My naive implementation of this would
be to get the VisibleSelection and check if isNone() is true, but I'm sure
there's better ways of doing it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list