[Webkit-unassigned] [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25415


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31049|review?                     |review+
               Flag|                            |




------- Comment #28 from jmalonzo at gmail.com  2009-06-10 04:05 PDT -------
(From update of attachment 31049)
> -static bool findCharacterAttributeSkip(isCharacterAttribute predicateFunction, unsigned skip, PangoLogAttr* attributes, Direction direction, int startOffset, int attrsLength, int* resultOffset)
> +static GailTextUtil* getGailTextUtilForAtk(AtkText* textObject)
>  {
> -    int tmpOffset;
> +    gpointer data = g_object_get_data(G_OBJECT(textObject), "webkit-accessible-gail-text-util");



>  static gchar* webkit_accessible_text_get_text_after_offset(AtkText* text, gint offset, AtkTextBoundary boundaryType, gint* startOffset, gint* endOffset)
>  {
> -    return getTextHelper(AfterOffset, text, offset, boundaryType, startOffset, endOffset);
> +    return gail_text_util_get_text(getGailTextUtilForAtk(text), NULL, GAIL_AFTER_OFFSET, boundaryType, offset, startOffset, endOffset);
>  }
>  
>  static gchar* webkit_accessible_text_get_text_at_offset(AtkText* text, gint offset, AtkTextBoundary boundaryType, gint* startOffset, gint* endOffset)
>  {
> -    return getTextHelper(AtOffset, text, offset, boundaryType, startOffset, endOffset);
> +    return gail_text_util_get_text(getGailTextUtilForAtk(text), NULL, GAIL_AT_OFFSET, boundaryType, offset, startOffset, endOffset);
>  }
>  
>  static gchar* webkit_accessible_text_get_text_before_offset(AtkText* text, gint offset, AtkTextBoundary boundaryType, gint* startOffset, gint* endOffset)
>  {
> -    return getTextHelper(BeforeOffset, text, offset, boundaryType, startOffset, endOffset);
> +    return gail_text_util_get_text(getGailTextUtilForAtk(text), NULL, GAIL_BEFORE_OFFSET, boundaryType, offset, startOffset, endOffset);
>  }

Would be nice if we can refactor these in the future.

Looks fine. Are we OK with depending on libgail? If so, r=me.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.