[Webkit-unassigned] [Bug 26278] Patch that make WebCore have a RenderTheme per page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 21:14:19 PDT 2009


hyatt at apple.com changed:

           What    |Removed                     |Added
  Attachment #31105|review?(hyatt at apple.com)    |review-
               Flag|                            |

------- Comment #4 from hyatt at apple.com  2009-06-09 21:14 PDT -------
(From update of attachment 31105)
One improveement would be to avoid making new RenderThemes on platforms that
don't need per-page themes...

(1) Make RenderTheme refcounted.
(2) Make Page's theme() call a function like 

PassRefPtr<RenderTheme> RenderTheme::themeForPage(Page*).

(3) On platforms that want to have per-page theme support, this function could
construct a new theme and hand it back.

On platforms that don't need per-page theme support, they could just hand back
the static singleton as before (which should have an initial ref() also or
maybe be held in static RefPtr).

I'm not sure every RenderTheme subclass has made its data members and such
static, so I'm concerned about moving away from singletons on platforms that
don't need per-page support... hence the suggestion of a way to keep the
singleton model.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list