[Webkit-unassigned] [Bug 26148] Unfork RenderThemeChromium{Win, Linux}.{h, cc}

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 17:56:08 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26148


ajwong at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31119|                            |review?
               Flag|                            |




------- Comment #20 from ajwong at chromium.org  2009-06-09 17:56 PDT -------
Created an attachment (id=31119)
 --> (https://bugs.webkit.org/attachment.cgi?id=31119&action=view)
Remove common code from RenderThemeChromiumWin

Reviewing this one is going to be the difficult one.

The 2 checks I did was as follows:
  1) Verify that all functions in RenderThemeChromiumSkia were in the original
RenderThemeChromiumWin.
  2) Verify that all removed functions from RenderThemeChromiumWin were
identical to the Skai versions.

For check #1, I found two functions that slipped through last time.

  supportsControlTint -> Moved to RenderThemeChromiumLinux
  platformTextSearchHighlightColor -> This isn't in RenderTheme.  Removed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list