[Webkit-unassigned] [Bug 15457] Realplayer plugin does not work correctly if the OBJECT tags defined with the "DATA" attribute has a URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15457





------- Comment #10 from eric at webkit.org  2009-06-09 01:47 PDT -------
(From update of attachment 31082)
I don't fully understand Anders comment above since you already seem to have
answered at least one of his questions in comment 5 and comment 2.

I still think this would read better if the code was broken out into a static
function something like:
static  void mapDataToSrcForOldPlugins(Vector<String>& paramNames,
Vector<String>& paramValues)
{ ... }

I'm not sure if .lower() or equalIgnoringCase is faster.  equalIgnoringCase
does avoid the allocation caused by lower() though.

Having looked at the FF source and read your additional comments, I agree, we
should make this change.  You should consider referencing the FF source in your
ChangeLog.

We still need a reply from Anders, but I'm ready to r+ this otherwise.  I'd
love to see a new patch w/ the nits fixed, but otherwise this is ready to go.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.