[Webkit-unassigned] [Bug 16148] overflow: hidden with float:left rendering issue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16148





------- Comment #5 from jacob.refstrup at hp.com  2009-06-08 23:06 PDT -------
(In reply to comment #4)
> (From update of attachment 30742 [review])
> Pretty sure it's impossible for width to be negative, so once you've changed it
> to >= 0 it's equivalent to just not having that in the if statement at all.
> 
> Also, you need to patch RenderFlexibleBox::calcPrefWidths, as it has the same
> mistake.
> 

Good catch :-) I'll go ahead and remove the >= 0 and fix the
RenderFlexibleBox::calcPrefWidths and simplify the added test case.

Your opinion on whether a similar fix should be applied to the tableCell case
that's approx 21 lines below:

        if (isTableCell()) {
            Length w = static_cast<const
RenderTableCell*>(this)->styleOrColWidth();
            if (w.isFixed() && w.value() > 0)
                m_maxPrefWidth = max(m_minPrefWidth,
calcContentBoxWidth(w.value()));
        }

?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.