[Webkit-unassigned] [Bug 26214] RenderTextControl: Remove ASSERT for checking that visiblePositionForIndex()'s return is not null.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 8 20:24:38 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=26214
------- Comment #3 from tyoshino at google.com 2009-06-08 20:24 PDT -------
(In reply to comment #2)
> (From update of attachment 31000 [review])
> Why does this need to be guarded in an if? Doesn't VisibleSelection(foo, null)
> result in an empty selection? or does that ASSERT too?
>
Yes, creation of VisibleSelection can be put outside if-clause. Fixed.
The line
ASSERT(startPosition.deepEquivalent().node()->shadowAncestorNode() == node() &&
endPosition.deepEquivalent().node()->shadowAncestorNode() == node());
must be guarded into if-clause because deepEquivalent() can be null. In fact, I
observe shadowAncestorNode() called with this=null.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list